fix: calculator inputs placeholder#967
Merged
Merged
Conversation
ovitrif
changed the title
ovitrif
force-pushed
the
fix/calc-placeholder
branch
from
20a10ad to
cdc3eb1
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ovitrif
force-pushed
the
fix/calc-placeholder
branch
from
45852b3 to
88559ff
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
61 tasks
jvsena42
approved these changes
May 26, 2026
Member
jvsena42
left a comment
jvsena42
left a comment
There was a problem hiding this comment.
Tested
- Switch between classical/modern -> BTC input updated
- Change currency -> Conversion updated
- Close the app
- Physical keyboard
Collaborator
|
Testing Notes
The only thing is that https://bitkit.stag0.blocktank.to/fx/rates/btc has some pairs stale (e.g. BTCUSD) which causes mismatches in staging build. Flagged in https://synonymworkspace.slack.com/archives/C03UWHGKUNP/p1779786482683179, but perhaps we can just consider using https://blocktank.synonym.to/fx/rates/btc for all builds across the board. |
piotr-iohk
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports calculator widget fixes from:
Description
This PR:
0as the empty placeholder for modern bitcoin and fiat calculator inputs.0.00000000for empty classic bitcoin input and keeps the classic decimal placeholder tail for whole bitcoin values.Note Didn't add any changelog fragment because this is considered one unit of work in iOS as well and part of the calculator v61 redesign, should've been part of #942 ideally.
Preview
placeholder2x.mp4
QA Notes
Manual Tests
0.0.00000000.0placeholder.Automated Checks
app/src/test/java/to/bitkit/ui/screens/widgets/calculator/components/CalculatorCardStateTest.kt.app/src/test/java/to/bitkit/ui/screens/widgets/calculator/components/CalculatorCardStateTest.ktand rate/currency refresh handling inapp/src/test/java/to/bitkit/ui/screens/widgets/calculator/CalculatorViewModelTest.kt../gradlew testDevDebugUnitTest --tests to.bitkit.ui.screens.widgets.calculator.CalculatorViewModelTest --tests to.bitkit.ui.screens.widgets.calculator.components.CalculatorCardStateTest;./gradlew compileDevDebugKotlin testDevDebugUnitTest detekt.